From: Tejun Heo <tj@kernel.org>
To: Daniel Collins <solemnwarning@solemnwarning.no-ip.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.28 /proc/diskstats
Date: Tue, 14 Apr 2009 16:52:57 +0900 [thread overview]
Message-ID: <49E440D9.4020803@kernel.org> (raw)
In-Reply-To: <49E13D18.2090805@solemnwarning.net>
Daniel Collins wrote:
> Hi
>
> Since 2.6.28, fd0 isn't visible in /proc/diskstats from boot, only after
> access/mount. It is visible in /sys/block/ from boot, so there are no
> issues detecting it. This may also affect other devices such as hda but
> I haven't tested this yet, my test system and QEMU both only have
> ram0-ram15 from boot. I have tested 2.6.30-rc1 and found the same
> behavior. Is this a bug or a deliberate change?
Hmm... the reason why fd device is skipped before the first open is
because diskstats_show() skips zero sized devices and open is when the
floppy driver sets the capacity. I think the original code also
skipped zero sized device. It could be that the original code
triggered revalidation while the current one doesn't. I'll dig
deeper.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-04-14 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 1:00 2.6.28 /proc/diskstats Daniel Collins
2009-04-12 1:50 ` Andrew Morton
2009-04-12 18:50 ` Daniel Collins
2009-04-13 1:21 ` Daniel Collins
2009-04-13 6:16 ` Sam Ravnborg
2009-04-14 7:52 ` Tejun Heo [this message]
2009-04-14 8:58 ` Tejun Heo
2009-04-14 8:59 ` [PATCH] block: include empty disks in /proc/diskstats Tejun Heo
2009-04-21 21:54 ` [stable] " Chris Wright
2009-04-22 5:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E440D9.4020803@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=solemnwarning@solemnwarning.no-ip.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.