From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ltdq7-0002zk-UT for mharc-grub-devel@gnu.org; Tue, 14 Apr 2009 04:17:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ltdq6-0002zR-Am for grub-devel@gnu.org; Tue, 14 Apr 2009 04:17:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ltdq1-0002yc-4b for grub-devel@gnu.org; Tue, 14 Apr 2009 04:17:53 -0400 Received: from [199.232.76.173] (port=44809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ltdq0-0002yZ-UC for grub-devel@gnu.org; Tue, 14 Apr 2009 04:17:49 -0400 Received: from smtp103.vzn.mail.re1.yahoo.com ([69.147.103.190]:24720) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Ltdq0-0002rT-Lr for grub-devel@gnu.org; Tue, 14 Apr 2009 04:17:48 -0400 Received: (qmail 57446 invoked from network); 14 Apr 2009 08:17:48 -0000 Received: from unknown (HELO ?192.168.2.5?) (jpsinthemix@68.239.115.78 with plain) by smtp103.vzn.mail.re1.yahoo.com with SMTP; 14 Apr 2009 08:17:46 -0000 X-YMail-OSG: z1z2l.kVM1mqdcsF1uRiBisHCRXcsO2GfPYFq7VtTS9qfrPtwj9CV3oLW_aWPDwlRR6OPS3iV7r8R1kl.7MruZh70SSmQqn93R3CMyUfCckV76ybfLhfxpxYCuwBgGfWn187L8ear9VmQA_KHauvXe4WaV2FoI._n7wQvLhOPWPJj7hefBVi7x0C4Gg9RNimeNMKIHoIkEbVN1HtPRJpT0GQho4Yo7B_Q2jUKxm71LwZf9a5fDCDH2_xvNYi3a52OQUAt7kw3sIBB.RhV2IuQ8YUIfbMU_kERUNfpMndfFYN2w-- X-Yahoo-Newman-Property: ymail-3 Message-ID: <49E454B8.7060800@verizon.net> Date: Tue, 14 Apr 2009 05:17:44 -0400 From: John Stanley User-Agent: Thunderbird 2.0.0.21 (X11/20090302) MIME-Version: 1.0 To: The development of GRUB 2 , The development of GRUB 2 References: <49E3E185.3040609@verizon.net> <1239674082.14603.6.camel@mj> In-Reply-To: <1239674082.14603.6.camel@mj> Content-Type: multipart/mixed; boundary="------------020100050704080502020903" X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) Subject: Re: grub-fstest build issue in grub2-r2071 + X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 08:17:54 -0000 This is a multi-part message in MIME format. --------------020100050704080502020903 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit An update: I looked at the change between r2077 and r2104 and it looks like the relevant code is util/hostdisk.c; I've attached a patch that appears to fix the problem. John Hi Again, Thanks, r2104 builds with --enable-grub-fstest now, but a new problem, not present in r2101 has surfaced: the command grub-probe now aborts on my system with xfs filesystems. Therefore, I cannot run grub-install (even with --modules=xfs). With rev's 2101, 2087, 2077, 2071, and 2065 grub-probe ran without error. Here's my hd config: #device mount-point fs type options dump fsck /dev/hda1 swap swap defaults 0 0 /dev/hda2 / xfs defaults 1 1 and here's the output of grub-probe (r2104): # grub-probe -v --target=fs --device /dev/hda2 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd0 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: the size of hd1 is 156301488 grub-probe: info: /dev/hda2 starts from 2056320 grub-probe: info: opening the device hd0 grub-probe: info: the size of hd0 is 156301488 Aborted thanks again, John Pavel Roskin wrote: > On Mon, 2009-04-13 at 21:06 -0400, John Stanley wrote: > >> Hi all, >> >> I have built grub2-r2065 and it works nicely for me so far for linux >> boots (love the graphics!!). However, beginning with r2071, I am unable >> to build it with the "--enable-grub-fstest" option due to several >> undefined refs: >> > > It started in r2067. > > >> To handle this (I'm now building r2101), I add normal/datetime to the >> grub-fstest build specs, >> > > Fixed in subversion. Thank you! > > _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel --------------020100050704080502020903 Content-Type: text/plain; name="grub2-r2104-util_hostdisk.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="grub2-r2104-util_hostdisk.c.diff" *** grub2-r2104.orig/util/hostdisk.c 2009-04-13 23:06:08.000000000 -0400 --- grub2-r2104/util/hostdisk.c 2009-04-14 04:57:48.736246452 -0400 *************** *** 625,636 **** int len = strlen(map[drive].drive); char *p; ! if (dos_part >= 0) ! len += 1 + ((dos_part + 1) / 10); if (bsd_part >= 0) len += 2; ! p = xmalloc (len); sprintf (p, "%s", map[drive].drive); if (dos_part >= 0) --- 625,644 ---- int len = strlen(map[drive].drive); char *p; ! if (dos_part >= 0) { ! // Add in char length of dos_part+1 ! int tmp = dos_part + 1; ! ++len; ! while ( (tmp /= 10) ) len++; ! } if (bsd_part >= 0) len += 2; ! // Length to alloc is: char length of map[drive].drive, plus ! // char length of (dos_part+1) or of bsd_part, plus ! // 2 for the comma and a null/end of string (\0) ! p = xmalloc (len+2); ! sprintf (p, "%s", map[drive].drive); if (dos_part >= 0) --------------020100050704080502020903--