From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] pata_hpt37x: fix HPT370 DMA timeouts
Date: Tue, 14 Apr 2009 20:45:50 +0400 [thread overview]
Message-ID: <49E4BDBE.7070903@ru.mvista.com> (raw)
In-Reply-To: <20090414173507.136ac439@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>>The libata driver has copied the code from the IDE driver which caused a post
>>2.4.18 regression on many HPT370[A] chips -- DMA stopped to work completely,
>>only causing timeouts. Now remove hpt370_bmdma_start() for good...
> Do we need to move it rather than remove it though. I need to look at
> that a bit with my HPT370 and see what happens. I suspect that if we get
> a failed transfer we need to do the reset somewhere -
Well, the driver does the reset in hpt370_bmdma_stop(), and even twice.
> perhaps qc_issue before anything hits the chip for the command ?
No idea. I think it's just not needed.
MBR, Sergei
next prev parent reply other threads:[~2009-04-14 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 14:39 [PATCH] pata_hpt37x: fix HPT370 DMA timeouts Sergei Shtylyov
2009-04-14 16:35 ` Alan Cox
2009-04-14 16:45 ` Sergei Shtylyov [this message]
2009-04-15 9:30 ` Alan Cox
2009-04-16 19:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E4BDBE.7070903@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.