Re: [PATCH] libpcap: weaken bluez-libs dependency

[Graeme Gregory <dp@xora.org.uk>]

On 04/15/2009 09:36 AM, Roman I Khimov wrote:
> libpcap can be used in distros where no bluetooth support will ever
> exist. So this dependency should be weakened to only exist in distros
> that explicitly need bluetooth.
> ---
>   recipes/libpcap/libpcap.inc |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/libpcap/libpcap.inc b/recipes/libpcap/libpcap.inc
> index 4468a4b..81bf826 100644
> --- a/recipes/libpcap/libpcap.inc
> +++ b/recipes/libpcap/libpcap.inc
> @@ -2,7 +2,11 @@ DESCRIPTION = "Network Packet Capture Library"
>   HOMEPAGE = "http://www.tcpdump.org/"
>   SECTION = "libs/network"
>   LICENSE = "BSD"
> -DEPENDS = "bluez-libs flex-native bison-native"
> +DEPENDS = " \
> +	${@base_contains("COMBINED_FEATURES", "bluetooth", "bluez-libs", "", d)} \
> +	flex-native \
> +	bison-native \
> +	"
>
>   PR = "r1"
>
>    
NACK, this doesnt do what you think it does as you don't disable 
bluetooth via any form of alteration to the build system. You have 
created randomness in your build now.

Graeme