From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lu4VO-00037M-Ru for mharc-grub-devel@gnu.org; Wed, 15 Apr 2009 08:46:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lu4VK-00036G-OY for grub-devel@gnu.org; Wed, 15 Apr 2009 08:46:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lu4VE-00034q-Oh for grub-devel@gnu.org; Wed, 15 Apr 2009 08:46:13 -0400 Received: from [199.232.76.173] (port=60984 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lu4VE-00034a-C1 for grub-devel@gnu.org; Wed, 15 Apr 2009 08:46:08 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:46710) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lu4VD-0001dy-AP for grub-devel@gnu.org; Wed, 15 Apr 2009 08:46:07 -0400 Received: by fxm10 with SMTP id 10so3184774fxm.42 for ; Wed, 15 Apr 2009 05:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=e28YjnugQ2lk3qjM0B1kyO5sNsJPi2lzBMUs35ESPeo=; b=Kd5YsXfPIUnE32GlRbxW5sThESNwC3xh7PYobmO+49IbIOPpbnfjuK7aeI2dYubfge rpwA15aYP8l+gnm7kAA2O2o+RUwiQGZvX6+SO+clgdFS/4TlTKUM8cZQySSfeEPO7Q4d S/DKW22QodQUEd89/DpTGj65+jFsXecX2+i9k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=o5N4qkGyvSVnSQQU9ZTM5qgUNis+8P6bkTLcJozzFZOKzA+Qr/qmDlikcgepKVjQP3 CJ1hOOpWXSQnVwztQ8uX7xoX2IvSGx6RGKomIsNLtIgyABI6SRaYqAUC7S+y5QiGtmmB BCOPC3t68JzQTw7o4oSOR22gqaSKK9OmGEOaI= Received: by 10.86.81.15 with SMTP id e15mr156575fgb.2.1239799566202; Wed, 15 Apr 2009 05:46:06 -0700 (PDT) Received: from ?192.168.1.100? (121.88.202.62.cust.bluewin.ch [62.202.88.121]) by mx.google.com with ESMTPS id l12sm9958963fgb.21.2009.04.15.05.46.04 (version=SSLv3 cipher=RC4-MD5); Wed, 15 Apr 2009 05:46:05 -0700 (PDT) Message-ID: <49E5D70B.5030801@gmail.com> Date: Wed, 15 Apr 2009 14:46:03 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: The development of GRUB 2 References: <49C63395.9090304@gmail.com> <200904012252.26655.okuji@enbug.org> <20090401141932.GA28777@thorin> <200904012342.22787.okuji@enbug.org> <49D38446.6030302@gmail.com> <49D38692.9080201@nic.fi> <49D38C4C.4000407@gmail.com> <49D8CBF7.2000705@gmail.com> In-Reply-To: <49D8CBF7.2000705@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Move loader.c out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 12:46:15 -0000 Commited phcoder wrote: > On the IRC Yoshinori K. Okuji agreed that this move can be useful in > cases like lvm+raid and luks. Any further oppositions? > phcoder wrote: >> I was thinking about something more finished like the possibility of >> handling multiple preboot and to undo the operations in case of failed >> or returned boot. Potentially it could be moved to a separate module >> but it results in a reverse dependency and somewhat ugly code >> Vesa Jääskeläinen wrote: >>> phcoder wrote: >>>> This usage case isn't the main target case. If you embed the loader >>>> (which tend to be quite big) then you already have an overhead from >>>> loader module. Why are you so concerned with overhead of boot.mod? >>>> But on the other hand this forces all the people in other cases to have >>>> boot code in core.img. I want to add preboot hooks and don't want >>>> increment size of kernel. multiboot.mod currently increases the size by >>>> around 11KB. And my patch doesn't restrict you from putting loader in >>>> core.img in any way >>> >>> Even if you add the preboot hooks there, it should only cause size >>> affect in couple of bytes for uncompressed image. >>> >>> Like in following "sketch": >>> >>> ... >>> >>> preboot_handler_address: dd 0 >>> >>> ... >>> >>> cmp [preboot_handler_address], 0 >>> >>> je no_preboot_handler >>> >>> call [preboot_handler_address] >>> >>> no_preboot_handler: >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> http://lists.gnu.org/mailman/listinfo/grub-devel >> >> > > -- Regards Vladimir 'phcoder' Serbinenko