Re: [PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy <dedekind@yandex.ru>]

Artem Bityutskiy wrote:
> Disabling unused clock "gpt2_ick"
> Disabling unused clock "gpt3_ick"
> Disabling unused clock "gpt4_ick"
> Disabling unused clock "gpt5_ick"
> Disabling unused clock "gpt6_ick"
> Disabling unused clock "gpt7_ick"
> Disabling unused clock "gpt8_ick"
> Disabling unused clock "gpt9_ick"
> Disabling unused clock "gpio2_dbck"
> Disabling unused clock "gpio3_dbck"
> Disabling unused clock "gpio4_dbck"
> Disabling unused clock "gpio5_dbck"
> Disabling unused clock "gpio6_dbck"
> Disabling unused clock "gpt9_fck"
> Disabling unused clock "gpt8_fck"
> Disabling unused clock "gpt7_fck"
> Disabling unused clock "gpt6_fck"
> Disabling unused clock "gpt5_fck"
> Disabling unused clock "gpt4_fck"
> Disabling unused clock "gpt3_fck"
> Disabling unused clock "gpt2_fck"
> Disabling unused clock "wdt2_ick"
> Disabling unused clock "wdt2_fck"
> Disabling unused clock "gpio1_dbck"
> Disabling unused clock "rng_ick"
> Disabling unused clock "ssi_ick"
> Disabling unused clock "gpt10_ick"
> Disabling unused clock "gpt11_ick"
> Disabling unused clock "uart1_ick"
> Disabling unused clock "uart2_ick"
> Disabling unused clock "usbtll_ick"
> Disabling unused clock "ssi_ssr_fck"
> Disabling unused clock "uart1_fck"
> Disabling unused clock "uart2_fck"
> Disabling unused clock "usbtll_fck"
> Disabling unused clock "ts_fck"
> Disabling unused clock "cpefuse_fck"
> Disabling unused clock "gpt11_fck"
> Disabling unused clock "gpt10_fck"
> Disabling unused clock "dpll5_ck"
> Disabling unused clock "dpll4_m6x2_ck"
> Disabling unused clock "dpll4_m5x2_ck"
> Disabling unused clock "dpll3_m3x2_ck"
> Disabling unused clock "sys_clkout1"
> 
> The messages have KERN_INFO level and if you have serial
> console, they normally go there. I do not think it is good
> idea to print that much stuff there. Moreover, messages
> are not properly prefixed and for mortals it is not
> immeadietly clear where they come from.
> 
> Let's give them debugging level instead.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> ---
>  arch/arm/mach-omap2/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> index 4247a15..c4169ee 100644
> --- a/arch/arm/mach-omap2/clock.c
> +++ b/arch/arm/mach-omap2/clock.c
> @@ -1035,7 +1035,7 @@ void omap2_clk_disable_unused(struct clk *clk)
>  	if ((regval32 & (1 << clk->enable_bit)) == v)
>  		return;
>  
> -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
>  	if (cpu_is_omap34xx()) {
>  		omap2_clk_enable(clk);
>  		omap2_clk_disable(clk);

Few notes. I'm just trying to clean up our system, because
it prints too much to serial line. The clocks prints are
not very bad, but I still find them a little bit excessive.
Thus, suggested a patch.

But if you think PM is in a stage when it still needs
some debugging printing, I'm not going to insist, of course.
You could do this later, when stuff is more stable.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html