From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phylib: Fix delay argument of schedule_delayed_work
Date: Wed, 15 Apr 2009 20:37:19 +0200 [thread overview]
Message-ID: <49E6295F.80009@gmail.com> (raw)
In-Reply-To: <1239811551-6101-1-git-send-email-anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> The commit a390d1f3 ("phylib: convert state_queue work to
> delayed_work") missed converting 'expires' value to 'delay' value.
Yeah, sorry about that.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Acked-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> ---
> drivers/net/phy/phy.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 3ff1f42..5737b85 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -434,7 +434,7 @@ void phy_start_machine(struct phy_device *phydev,
> phydev->adjust_state = handler;
>
> INIT_DELAYED_WORK(&phydev->state_queue, phy_state_machine);
> - schedule_delayed_work(&phydev->state_queue, jiffies + HZ);
> + schedule_delayed_work(&phydev->state_queue, HZ);
> }
>
> /**
> @@ -937,6 +937,5 @@ static void phy_state_machine(struct work_struct *work)
> if (err < 0)
> phy_error(phydev);
>
> - schedule_delayed_work(&phydev->state_queue,
> - jiffies + PHY_STATE_TIME * HZ);
> + schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ);
> }
next prev parent reply other threads:[~2009-04-15 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 16:05 [PATCH] phylib: Fix delay argument of schedule_delayed_work Atsushi Nemoto
2009-04-15 18:37 ` Marcin Slusarz [this message]
2009-04-16 9:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E6295F.80009@gmail.com \
--to=marcin.slusarz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.