From: Yuta sugiura <ysugiura@miraclelinux.com>
To: netdev@vger.kernel.org
Subject: [IPV6]: ROUTE:read ifname in rt6_info_route()
Date: Thu, 16 Apr 2009 20:05:05 +0900 [thread overview]
Message-ID: <49E710E1.3060209@miraclelinux.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
Hi,
I have a suggestion about /proc/net/IPv6_route format.
In rt6_info_route(), interface name is treated as a maximum 8 characters.
But the type of (struct rt6_inf *)->u.dst.dev->name is char[IFNAMESIZ= 16]
so, I think that it should change "%8s" to "%16s".
Thanks,
[-- Attachment #2: ipv6_route_ifnamesiz.patch --]
[-- Type: text/plain, Size: 762 bytes --]
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 1394ddb..9ad58e7 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2434,7 +2434,7 @@ static int ip6_route_dev_notify(struct notifier_block *this,
#ifdef CONFIG_PROC_FS
-#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 40 + 5 + 1)
+#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 48 + 5 + 1)
struct rt6_proc_arg
{
@@ -2462,7 +2462,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
} else {
seq_puts(m, "00000000000000000000000000000000");
}
- seq_printf(m, " %08x %08x %08x %08x %8s\n",
+ seq_printf(m, " %08x %08x %08x %08x %16s\n",
rt->rt6i_metric, atomic_read(&rt->u.dst.__refcnt),
rt->u.dst.__use, rt->rt6i_flags,
rt->rt6i_dev ? rt->rt6i_dev->name : "");
next reply other threads:[~2009-04-16 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 11:05 Yuta sugiura [this message]
2009-04-16 11:38 ` [IPV6]: ROUTE:read ifname in rt6_info_route() David Miller
2009-04-16 15:30 ` Stephen Hemminger
2009-04-16 16:17 ` Brian Haley
2009-04-16 16:47 ` Andreas Schwab
2009-04-16 17:27 ` Stephen Hemminger
2009-04-17 3:44 ` Yuta sugiura
2009-04-17 10:24 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E710E1.3060209@miraclelinux.com \
--to=ysugiura@miraclelinux.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.