Re: [PATCH] hdspm: native float

[Clemens Ladisch <clemens@ladisch.de>]

Florian Faber wrote:
> > > > 	/* Switch to native float format if requested */
> > > > ...
> > > > 	hdspm_write(hdspm, HDSPM_controlRegister, hdspm->control_register);
> > 
> > This looks like a global change.  What happens when playback and
> > recording want to use different formats?
> 
> It is a global change. The only use case is for jack, and jack doesn't
> use different formats for input/output.

"Using aplay + arecord" is a second use case.  :-)

Anyway, at least add a check that the formats are actually the same
(like the checks for sample rate and period size).


Best regards,
Clemens