From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] Make BIOS irq0->inti2 override configurable from userspace Date: Thu, 16 Apr 2009 15:55:50 +0300 Message-ID: <49E72AD6.8010101@redhat.com> References: <1239315625-10101-1-git-send-email-eak@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Beth Kon Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33853 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbZDPMz4 (ORCPT ); Thu, 16 Apr 2009 08:55:56 -0400 In-Reply-To: <1239315625-10101-1-git-send-email-eak@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Beth Kon wrote: > These patches resolve the irq0->inti2 override issue, and get the hpet working > on kvm with and without -no-kvm-irqchip (i.e., when hpet takes over, it > disables userspace or in-kernel pit as appropriate). > > The irq0->inti2 override will always be used unless the kernel cannot do irq > routing (i.e., compatibility with old kernels). So if the kernel is capable, > userspace sets up irq0->inti2 via the irq routing interface, and adds the > irq0->inti2 override to the MADT interrupt source override table, > and the mp table (for the no-acpi case). > > A couple of months ago, Marcelo was seeing RHEL5 guests complain of invalid > checksum with these patches, but later he couldn't reproduce it, and I'm not > seeing it now. While all guests still need to be fully tested, everything > appears to be in order. I've tested on win2k864, win2k832, RHEL5.3 32 bit, > and ubuntu 8.10 64 bit. > Both patches look good. However, the bios in kvm-userspace.git is pretty old. To ease later merging, I'd like to update the bios first, so please rebase the patches once I've done that. It will take a few days since large merges are blocked while I struggle to get a working kvm-85 out. Please also separate the bios patches from qemu patches. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.