Re: [PATCH] MIPS: Include linux/errno.h from arch/mips/include/asm/compat.h

[David Daney <ddaney@caviumnetworks.com>]

Atsushi Nemoto wrote:
> On Fri, 10 Apr 2009 12:16:11 -0700, Ralf Baechle <ralf@linux-mips.org> wrote:
>> On Fri, Apr 10, 2009 at 11:41:35AM -0700, David Daney wrote:
>>
>>> The recent change that added #include <linux/seccomp.h> breaks
>>> (because EINVAL is not defined) when building
>>> arch/mips/kernel/asm-offsets.s if CONFIG_SECCOMP is not defined.
>>> Including errno.h fixes the problem.
>> NAK, <linux/seccomp.h> should include <linux/errno.h>.
> 
> Then how about this?
> 
> ------------------------------------------------------
> Subject: [PATCH] Do not include seccomp.h from compat.h
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> The compat.h does not need seccomp.h since TIF_32BIT was moved to
> thread_info.h
> 
> This fixes a build error of 64-bit kernel without CONFIG_SECCOMP.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Signed-off-by: David Daney <ddaney@caviumnetworks.com>

> ---
>  arch/mips/include/asm/compat.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/include/asm/compat.h b/arch/mips/include/asm/compat.h
> index 6c5b409..f58aed3 100644
> --- a/arch/mips/include/asm/compat.h
> +++ b/arch/mips/include/asm/compat.h
> @@ -3,7 +3,6 @@
>  /*
>   * Architecture specific compatibility types
>   */
> -#include <linux/seccomp.h>
>  #include <linux/thread_info.h>
>  #include <linux/types.h>
>  #include <asm/page.h>
> 
>