From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Greg KH <greg@kroah.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: fix file mode of trace and README
Date: Fri, 17 Apr 2009 13:52:53 +0800 [thread overview]
Message-ID: <49E81935.8060402@cn.fujitsu.com> (raw)
In-Reply-To: <20090417054447.GA6020@nowhere>
>> - trace_create_file("current_tracer", 0444, d_tracer,
>> + trace_create_file("current_tracer", 0644, d_tracer,
>> &global_trace, &set_tracer_fops);
>
>
>
> Oh!
> I wonder how much time we ran with this false permission.
> It clearly shows a bug in debugfs permission (or something
> near this this layer), we have be running with this file
> for a while and I've never seen any issue while writing into it.
>
> And we have seen several patches with 0444 permissions for the
> tracing tree containing writeable files, showing that the authors
> ran them whithout problems.
>
It's not a bug in debugfs or vfs. It's just because root can
do anything. ;)
> Adding Greg in Cc.
>
next prev parent reply other threads:[~2009-04-17 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 2:34 [PATCH] tracing: fix file mode of trace and README Li Zefan
2009-04-17 5:44 ` Frederic Weisbecker
2009-04-17 5:52 ` Li Zefan [this message]
2009-04-17 16:10 ` [tip:tracing/core] " tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E81935.8060402@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.