From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LujU6-00054E-W0 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 04:31:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LujU1-000525-0h for qemu-devel@nongnu.org; Fri, 17 Apr 2009 04:31:41 -0400 Received: from [199.232.76.173] (port=46864 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LujU0-000522-RD for qemu-devel@nongnu.org; Fri, 17 Apr 2009 04:31:36 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:15374) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LujU0-0005mw-Ay for qemu-devel@nongnu.org; Fri, 17 Apr 2009 04:31:36 -0400 Message-ID: <49E83E62.3040006@siemens.com> Date: Fri, 17 Apr 2009 10:31:30 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1239944809-14327-1-git-send-email-zamsden@redhat.com> <49E8292A.8080900@web.de> <49E8332D.8090500@redhat.com> In-Reply-To: <49E8332D.8090500@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Fix changing password using monitor over VNC. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zachary Amsden Cc: qemu-devel@nongnu.org Zachary Amsden wrote: > Jan Kiszka wrote: >> Zachary Amsden wrote: >>> A simple segfault turned out to be a relatively complex fix. >>> >>> The monitor calls back to main_loop_wait() to wait for the completion >>> of the password change event; this results in a nested invocation of >> This is no longer true with trunk as this nasty blocking password >> reading has been converted into an async operation. Is your patch >> required nevertheless? Or is this band-aid for stable? > > I confirmed the bug, verified the fix on a git tree sync'd today from > git://git.savannah.nongnu.org/qemu.git > > let me know if this is not the trunk. Nope, it's outdated. Last check in is from end of January this year. There are several up-to-date git mirrors, one e.g. at kernel.org: git://git.kernel.org/pub/scm/virt/qemu/qemu.git. However, I prefer to do my own mirroring with git svn. > > Sorry, as I am new to qemu development. No problem. The issue you found is probably still relevant for stable 0.10.x, so please consider this branch as well. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux