From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Subject: Re: [Bug #13058] First hibernation attempt fails Date: Fri, 17 Apr 2009 10:38:00 +0100 Message-ID: <49E84DF8.7030802@tuffmail.co.uk> References: <20090417063007.GB4593@kernel.dk> <49E83DC4.8040207@tuffmail.co.uk> <20090417091321.GP4593@kernel.dk> <20090417093359.GQ4593@kernel.dk> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=/lK7CGCzb8STmtbGM/mPDasuZ4Q5WTT4muemLCjv3Ek=; b=YLbfV3q/K/RY+M2f/ocTTgjo7J6gWr8Zyjn/fhRK/hxfozyE4N+42WOed4CH99IKxc KyZhT4Quxof+2c2yrCR+eS31oqNGinrG82GDYR+4xiz8IYq0DORxOnER2EwYhoUDfAUK baTtAGL0o+QrYS0HBwL+Vjvqfz1G88gczodiI= In-Reply-To: <20090417093359.GQ4593@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jens Axboe Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Linus Torvalds Jens Axboe wrote: > On Fri, Apr 17 2009, Jens Axboe wrote: > >> On Fri, Apr 17 2009, Alan Jenkins wrote: >> >>> Jens Axboe wrote: >>> >>>> On Thu, Apr 16 2009, Rafael J. Wysocki wrote: >>>> >>>> >>>>> This message has been generated automatically as a part of a report >>>>> of recent regressions. >>>>> >>>>> The following bug entry is on the current list of known regressions >>>>> from 2.6.29. Please verify if it still should be listed and let me know >>>>> (either way). >>>>> >>>>> >>>>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13058 >>>>> Subject : First hibernation attempt fails >>>>> Submitter : Alan Jenkins >>>>> Date : 2009-04-10 10:58 (7 days old) >>>>> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1faa16d22877f4839bd433547d770c676d1d964c >>>>> References : http://marc.info/?l=linux-kernel&m=123928022321917&w=2 >>>>> >>>>> >>>> Alan, is this still a problem? >>>> >>>> >>> Yup. Still present in v2.6.30-rc2-195-g9f76208. >>> >> Given the somewhat odd nature of the bug and the requirements to trigger >> it, how confident are you in the bisection results? >> >> I'll try and reproduce it here. >> > > I can't reproduce it here. It seems very odd that an ENOMEM would happen > as a consequence of the rq allocation change, it doesn't really change > the allocation at all (and it'll never return -ENOMEM). > > Can you please recheck the git bisect results. It'd be nice if the > hibernation failure would actually log where the problem occured... > Once I found the right conditions (wireless disabled and a specific KDE session), it was 100% reproducible. Reverting your commit fixed the problem. I can do another test of that if you like. My _bisection_ was not absolute, rock-solid certain because I only found the right conditions half-way through. There's always the possibility I would get different results if I redid it properly, from the start. But I have some experience of this and took care to re-validate my upper & lower bounds.