From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 05/15] Coalesce userspace/kernel irqchip interrupt injection logic. Date: Fri, 17 Apr 2009 14:50:10 +0200 Message-ID: <49E87B02.4090302@siemens.com> References: <1239616545-25199-1-git-send-email-gleb@redhat.com> <1239616545-25199-6-git-send-email-gleb@redhat.com> <49E87867.3050506@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: avi@redhat.com, kvm@vger.kernel.org, joerg.roedel@amd.com, sheng@linux.intel.com To: Gleb Natapov Return-path: Received: from gecko.sbs.de ([194.138.37.40]:20719 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbZDQMum (ORCPT ); Fri, 17 Apr 2009 08:50:42 -0400 In-Reply-To: <49E87867.3050506@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Gleb Natapov wrote: >> + switch (type) { >> + case SVM_EXITINTINFO_TYPE_NMI: >> + svm->vcpu.arch.nmi_injected = true; >> + break; >> + case SVM_EXITINTINFO_TYPE_EXEPT: >> + if (exitintinfo & SVM_EXITINTINFO_VALID_ERR) { >> + u32 err = svm->vmcb->control.exit_int_info_err; >> + kvm_queue_exception_e(&svm->vcpu, vector, err); >> + > > stgit remarked "trailing whitespace". checkpatch.pl would probably do > so, too. :) > > And there is another one in patch 14. Sorry, the latter one was due to /me using the old version. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux