From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfilter: nfnetlink: return ENOMEM if we fail to create netlink socket
Date: Fri, 17 Apr 2009 17:50:39 +0200 [thread overview]
Message-ID: <49E8A54F.7000704@trash.net> (raw)
In-Reply-To: <20090417090548.11291.94506.stgit@Decadence>
Pablo Neira Ayuso wrote:
> With this patch, nfnetlink returns -ENOMEM instead of -EPERM if we
> fail to create the nfnetlink netlink socket during the module
> loading. This is exactly what rtnetlink does in this case.
Also applied, thanks.
> Ideally, it would be better if we propagate the error that has
> happened in netlink_kernel_create(), however, this function still
> does not implement this yet.
Agreed, but AFAICS netlink_kernel_create() only returns an error
on memory shortage, so this is fine currently.
prev parent reply other threads:[~2009-04-17 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 9:05 [PATCH 0/2] minor netfilter fixes for 2.6.30-rc Pablo Neira Ayuso
2009-04-17 9:05 ` [PATCH 1/2] netfilter: ctnetlink: report error if event message allocation fails Pablo Neira Ayuso
2009-04-17 9:17 ` Pablo Neira Ayuso
2009-04-17 15:47 ` Patrick McHardy
2009-04-17 9:05 ` [PATCH 2/2] netfilter: nfnetlink: return ENOMEM if we fail to create netlink socket Pablo Neira Ayuso
2009-04-17 15:50 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8A54F.7000704@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.