All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Beth Kon <eak@us.ibm.com>, Alexander Graf <agraf@suse.de>,
	Gleb Natapov <gleb@redhat.com>,
	Dmitry Eremin-Solenikov <dmitry.baryshkov@siemens.com>
Subject: Re: [Qemu-devel] [PATCH][STABLE] hpet: Fix emulation of HPET_TN_SETVAL
Date: Fri, 17 Apr 2009 16:21:13 -0500	[thread overview]
Message-ID: <49E8F2C9.9050705@us.ibm.com> (raw)
In-Reply-To: <49E79023.5090107@web.de>

Jan Kiszka wrote:
> While Intel's spec is not that clear here, latest changes to Linux' HPET
> code (commit c23e253e67c9d8a91a0ffa33c1f571a17f0a2403, "x86: hpet: stop
> HPET_COUNTER when programming periodic mode") strongly suggest that
> HPET_TN_SETVAL rather means: Set _both_ the comparator value and
> register.
>
> With this patch applied, I'm again able to boot 2.6.30-rc kernels as
> they no longer panic like this (which was due to the comparator
> register remaining 0):
>
> ENABLING IO-APIC IRQs
> ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
> ..MP-BIOS bug: 8254 timer not connected to IO-APIC
> ...trying to set up timer (IRQ0) through the 8259A ...
> ..... (found apic 0 pin 2) ...
> ....... failed.
> ...trying to set up timer as Virtual Wire IRQ...
> ..... failed.
> ...trying to set up timer as ExtINT IRQ...
> ..... failed :(.
> Kernel panic - not syncing: IO-APIC + timer doesn't work! [...]
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   
Applied to trunk and stable.  Thanks.

-- 
Regards,

Anthony Liguori

      reply	other threads:[~2009-04-17 21:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 20:08 [Qemu-devel] [PATCH][STABLE] hpet: Fix emulation of HPET_TN_SETVAL Jan Kiszka
2009-04-17 21:21 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E8F2C9.9050705@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=agraf@suse.de \
    --cc=dmitry.baryshkov@siemens.com \
    --cc=eak@us.ibm.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.