All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Kevin Wolf <mail@kevin-wolf.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
Date: Fri, 17 Apr 2009 17:31:50 -0500	[thread overview]
Message-ID: <49E90356.1090305@us.ibm.com> (raw)
In-Reply-To: <200904180029.06432@kevin-wolf.de>

Kevin Wolf wrote:
> Am Samstag, 18. April 2009 00:07 schrieben Sie:
>   
>> Every patch I commit gets tested.  I have various tests that I run
>> depending on which subsystem the patch touches.  Right now, for qcow2, I
>> don't have nearly enough.  I was hoping that Christoph had something
>> laying around that I could use since it looks like qemu-io would be a
>> great harness for qcow2 changes.
>>     
>
> It is, definitely. qemu-io is the other part which I needed. But qemu-io alone 
> won't make you happy. It can exercise a lot of code, but it can't tell you if 
> your image is broken in the end. Except for reading back written data, of 
> course, but breakage is often enough more subtle.
>
>   
>> But I can write a pretty easy script myself on top of qemu-io so it's no
>> big deal.  I'm not suggesting holding up development.
>>     
>
> Heh, so everyone is writing his own scripts. What would you think about 
> bringing the test cases you use into the repository?
>   

Yeah, I've been wanting to do everything via kvm-autotest but so far, 
it's not quite up to what I want to use it for.  I'll see about cleaning 
up some of my scripts and posting them.  The problem is they rely on 
custom images.

-- 
Regards,

Anthony Liguori

  reply	other threads:[~2009-04-17 22:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17 12:04 [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Kevin Wolf
2009-04-17 12:40 ` [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() Kevin Wolf
2009-04-17 14:01 ` kwolf
2009-04-17 20:39   ` Anthony Liguori
2009-04-17 21:00     ` Kevin Wolf
2009-04-17 21:03       ` Anthony Liguori
2009-04-17 21:19         ` Kevin Wolf
2009-04-17 22:07           ` Anthony Liguori
2009-04-17 22:29             ` Kevin Wolf
2009-04-17 22:31               ` Anthony Liguori [this message]
2009-04-18  0:11                 ` Ryan Harper
2009-04-20 13:48                 ` Christoph Hellwig
2009-04-21 16:19         ` Kevin Wolf
2009-04-20 13:46     ` Christoph Hellwig
2009-04-21 23:12   ` Anthony Liguori
2009-04-17 14:01 ` [Qemu-devel] [PATCH 2/5] Introduce bdrv_check kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 3/5] Introduce qemu-img check subcommand kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 4/5] qcow2: Refcount checking code cleanup kwolf
2009-04-21  8:32   ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2009-04-17 14:02 ` [Qemu-devel] [PATCH 5/5] qcow2: Add plausibility check for L1/L2 entries kwolf
2009-04-20 10:30 ` [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E90356.1090305@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=hch@infradead.org \
    --cc=kwolf@redhat.com \
    --cc=mail@kevin-wolf.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.