Re: [PATCH 02/02] sata_mv: workaround for multi_count errata sata24

[Mark Lord <liml@rtr.ca>]

Jeff Garzik wrote:
> Mark Lord wrote:
>> Workaround for errata SATA#24 in sata_mv.
>> This errata affects WRITE_MULTI* commands when
>> the device multi_count produces a DRQ block size >= 4Kbytes.
>>
>> We work around it here by converting such operations
>> into ordinary PIO_WRITEs instead.
>>
>> Note that this might result in a PIO FUA write unavoidably being 
>> converted
>> into a non-FUA write.  In practice, any system using FUA is also going 
>> to be
>> using DMA rather than PIO, so this shouldn't affect anyone in the real 
>> world.
> 
> I'm applying this, but I think a follow-up patch would be nice:  it 
> seems like a one-time printk, indicating the FUA conversion is active, 
> could be a help in case someone does care.
..

Seems like .text bloat to me.

But if you want it, I'll cook up patches for both ata_rwcmd_protocol()
in libata-core.c as well as sata_mv.c later on.

Cheers