From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lv66s-0003eG-Mn for qemu-devel@nongnu.org; Sat, 18 Apr 2009 04:41:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lv66n-0003ck-EC for qemu-devel@nongnu.org; Sat, 18 Apr 2009 04:41:13 -0400 Received: from [199.232.76.173] (port=45878 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lv66n-0003cc-2w for qemu-devel@nongnu.org; Sat, 18 Apr 2009 04:41:09 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:54063) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lv66m-0001nq-4a for qemu-devel@nongnu.org; Sat, 18 Apr 2009 04:41:08 -0400 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id B15C9FAAF0D4 for ; Sat, 18 Apr 2009 10:41:05 +0200 (CEST) Received: from [88.65.39.244] (helo=[192.168.1.123]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1Lv66j-000718-00 for qemu-devel@nongnu.org; Sat, 18 Apr 2009 10:41:05 +0200 Message-ID: <49E99220.3030608@web.de> Date: Sat, 18 Apr 2009 10:41:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1239944809-14327-1-git-send-email-zamsden@redhat.com> <49E8292A.8080900@web.de> <49E8332D.8090500@redhat.com> <49E83E62.3040006@siemens.com> <49E94975.20408@redhat.com> In-Reply-To: <49E94975.20408@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF99059F21F4BA50A8D6134BF" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] Fix changing password using monitor over VNC. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF99059F21F4BA50A8D6134BF Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Zachary Amsden wrote: > Jan Kiszka wrote: >> Zachary Amsden wrote: >>> Jan Kiszka wrote: >>>> Zachary Amsden wrote: >>>>> A simple segfault turned out to be a relatively complex fix. >>>>> >>>>> The monitor calls back to main_loop_wait() to wait for the completi= on >>>>> of the password change event; this results in a nested invocation o= f >>>> This is no longer true with trunk as this nasty blocking password >>>> reading has been converted into an async operation. Is your patch >>>> required nevertheless? Or is this band-aid for stable? >>> I confirmed the bug, verified the fix on a git tree sync'd today from= >>> git://git.savannah.nongnu.org/qemu.git >>> >>> let me know if this is not the trunk. >> Nope, it's outdated. Last check in is from end of January this year. >> >> There are several up-to-date git mirrors, one e.g. at kernel.org: >> git://git.kernel.org/pub/scm/virt/qemu/qemu.git. However, I prefer to = do >> my own mirroring with git svn. >> >>> Sorry, as I am new to qemu development. >> No problem. The issue you found is probably still relevant for stable >> 0.10.x, so please consider this branch as well. >=20 > The patch applies as is to stable branch. >=20 > And this new patch fixes two bugs on trunk: >=20 > 1) Changing VNC password should set password auth if it wasn't yet enab= led > 2) Trying to change VNC password on a SDL-only display gives a segfault= =2E >=20 I thought I fixed something like 2) along the monitor rework, but obviously not every case (VNC is not in daily use here). However, your patch requires standard format: [PATCH] (if it starts with 'Re:', it risks to be overseen) Signed-off-by: ... Thanks, Jan --------------enigF99059F21F4BA50A8D6134BF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAknpkiAACgkQniDOoMHTA+lnQQCff5lqE+ddI/vV5WDXqjyH+rj6 0/AAn01OQrn4uvpS8z/pr5eF2vA+3Tti =lMdL -----END PGP SIGNATURE----- --------------enigF99059F21F4BA50A8D6134BF--