All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: petkovbb@gmail.com
Cc: petkovbb@googlemail.com, bzolnier@gmail.com, axboe@kernel.dk,
	linux-ide@vger.kernel.org,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH 12/15] ide-cd: convert to using generic sense request
Date: Sun, 19 Apr 2009 18:30:49 +0900	[thread overview]
Message-ID: <49EAEF49.2040200@gmail.com> (raw)
In-Reply-To: <49EAEEB8.10300@kernel.org>

Tejun Heo wrote:
>> However, is there any reason for copying back the sense bytes at all?
>> In other words, does the block layer code need sense data when ending a
>> request or is it used only by LLDDs for error handling?

And, yes, SG_IO requests need sense data copied back.

Thanks.

-- 
tejun

  reply	other threads:[~2009-04-19  9:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17  9:33 [PATCHSET pata-2.6] ide: rq->buffer, data, special and misc cleanups, take#2 Tejun Heo
2009-04-17  9:33 ` [PATCH 01/15] block: clear req->errors on bio completion only for fs requests Tejun Heo
2009-04-17  9:33 ` [PATCH 02/15] ide-tape: remove back-to-back REQUEST_SENSE detection Tejun Heo
2009-04-17 10:23   ` Borislav Petkov
2009-04-17 10:35     ` Tejun Heo
2009-04-17 10:40       ` Tejun Heo
2009-04-17 11:03         ` Borislav Petkov
2009-04-17 21:12           ` Tejun Heo
2009-04-17 21:27             ` Mark Lord
2009-04-18 19:48             ` Borislav Petkov
2009-04-18 21:39               ` Tejun Heo
2009-04-19  7:28                 ` Borislav Petkov
2009-04-19  7:36                   ` Tejun Heo
2009-04-18 16:51     ` Bartlomiej Zolnierkiewicz
2009-04-18 21:42       ` Tejun Heo
2009-04-17  9:33 ` [PATCH 03/15] ide: use blk_run_queue() instead of blk_start_queueing() Tejun Heo
2009-04-17  9:33 ` [PATCH 04/15] ide: don't set REQ_SOFTBARRIER Tejun Heo
2009-04-17  9:33 ` [PATCH 05/15] ide kill unused ide_cmd->special Tejun Heo
2009-04-17  9:33 ` [PATCH 06/15] ide-cd: clear sense buffer before issuing request sense Tejun Heo
2009-04-17  9:33 ` [PATCH 07/15] ide-floppy: block pc always uses bio Tejun Heo
2009-04-17  9:33 ` [PATCH 08/15] ide-taskfile: don't abuse rq->buffer Tejun Heo
2009-04-17  9:33 ` [PATCH 09/15] ide-atapi: " Tejun Heo
2009-04-17  9:33 ` [PATCH 10/15] ide-cd: " Tejun Heo
2009-04-17  9:33 ` [PATCH 11/15] ide: add helpers for preparing sense requests Tejun Heo
2009-04-17  9:33 ` [PATCH 12/15] ide-cd: convert to using generic sense request Tejun Heo
2009-04-19  9:22   ` Borislav Petkov
2009-04-19  9:28     ` Tejun Heo
2009-04-19  9:30       ` Tejun Heo [this message]
2009-04-17  9:33 ` [PATCH 13/15] ide-atapi: convert ide-{floppy,tape} to using preallocated sense buffer Tejun Heo
2009-04-17  9:33 ` [PATCH 14/15] ide-cd,atapi: use bio for internal commands Tejun Heo
2009-04-17  9:33 ` [PATCH 15/15] ide-pm: don't abuse rq->data Tejun Heo
2009-04-18 16:32 ` [PATCHSET pata-2.6] ide: rq->buffer, data, special and misc cleanups, take#2 Bartlomiej Zolnierkiewicz
2009-04-18 20:04   ` Borislav Petkov
2009-04-18 21:43   ` Tejun Heo
2009-04-18 22:04     ` [GIT PATCH " Tejun Heo
2009-04-20 11:47       ` Bartlomiej Zolnierkiewicz
2009-04-20 11:59         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EAEF49.2040200@gmail.com \
    --to=htejun@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bzolnier@gmail.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-ide@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.