From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
rakib.mullick@gmail.com, akpm@linux-foundation.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86: Fix false positive section mismatch warnings in the apic code
Date: Sun, 19 Apr 2009 12:19:57 +0200 [thread overview]
Message-ID: <49EAFACD.6040302@gmail.com> (raw)
In-Reply-To: <20090419095759.GA4808@elte.hu>
Ingo Molnar wrote:
> * Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
>
>> tip-bot for Rakib Mullick pisze:
>>> Commit-ID: aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7
>>> Gitweb: http://git.kernel.org/tip/aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7
>>> Author: Rakib Mullick <rakib.mullick@gmail.com>
>>> AuthorDate: Sun, 19 Apr 2009 08:41:17 +0600
>>> Committer: Ingo Molnar <mingo@elte.hu>
>>> CommitDate: Sun, 19 Apr 2009 11:28:18 +0200
>>>
>>> x86: Fix false positive section mismatch warnings in the apic code
>>>
>>> find_unisys_acpi_oem_table() and unmap_unisys_acpi_oem_table()
>>> are non init functions, but these functions calls some init
>>> functions. But we need these functions as non-init functions.
>> Why? This warning seems to be valid.
>
> It's put into struct apic::acpi_madt_oem_check - which is a non-init
> structure. That particular field is only used from init context -
> but other fields are used all the time.
Can we have a rule that "every __ref usage should have a comment explaining
why __ref is safe in this place"?
Marcin
next prev parent reply other threads:[~2009-04-19 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 2:41 [PATCH] x86: Fix section mismatches in apic Rakib Mullick
2009-04-19 9:30 ` [tip:x86/urgent] x86: Fix false positive section mismatch warnings in the apic code tip-bot for Rakib Mullick
2009-04-19 9:47 ` Marcin Slusarz
2009-04-19 9:57 ` Ingo Molnar
2009-04-19 10:19 ` Marcin Slusarz [this message]
2009-04-19 13:56 ` Ingo Molnar
2009-04-19 11:16 ` Sam Ravnborg
2009-04-20 4:00 ` Rakib Mullick
2009-05-01 11:46 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-05-09 9:35 [PATCH] x86: Fix false positive section mismatch in apic Rakib Mullick
2009-05-10 7:30 ` [tip:x86/urgent] x86: Fix false positive section mismatch warnings in the apic code tip-bot for Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EAFACD.6040302@gmail.com \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rakib.mullick@gmail.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.