From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 13/15] Add NMI injection support to SVM. Date: Sun, 19 Apr 2009 15:59:09 +0200 Message-ID: <49EB2E2D.7060502@web.de> References: <1239616545-25199-1-git-send-email-gleb@redhat.com> <1239616545-25199-14-git-send-email-gleb@redhat.com> <49E8DEC1.4030802@web.de> <20090419131735.GG10126@redhat.com> <49EB2559.4000704@redhat.com> <20090419132434.GH10126@redhat.com> <49EB26E9.4060002@redhat.com> <20090419134005.GL10126@redhat.com> <49EB2A8D.603@web.de> <49EB2BDE.10206@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEAE02D4D43980BF9C68F19A0" Cc: Gleb Natapov , kvm@vger.kernel.org, joerg.roedel@amd.com, sheng@linux.intel.com, Dmitry Baryshkov To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:49583 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755012AbZDSN7P (ORCPT ); Sun, 19 Apr 2009 09:59:15 -0400 In-Reply-To: <49EB2BDE.10206@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEAE02D4D43980BF9C68F19A0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Jan Kiszka wrote: >> We already spent to much electrons and brain cycles on possibly "much >> simpler" workarounds. I think injecting and handling a single-step, ev= en >> while there is guest debugging going on or the guest itself single-ste= ps >> or both, will not be more complicated - but "more correct". >> =20 >=20 > I agree. I'm still worried about interactions between the IRET single > stepping code and other things which use the debug registers. The interaction is inside KVM, so under our control. We may simply save the related states, hook into the guest-debugging parts that evaluate single step exceptions, and handle this case with highest prio, transparently to users of lower prio. In theory - you never really know until you tried to implement it... Jan --------------enigEAE02D4D43980BF9C68F19A0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAknrLjEACgkQniDOoMHTA+k24QCePEqX5FqZ0+o7cTnIstmWUdob 0wkAn0QlCXI7dJjhX1GK4WqnjSwf08SB =btqX -----END PGP SIGNATURE----- --------------enigEAE02D4D43980BF9C68F19A0--