All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Marvell MV88F6281GTW_GE Board support
Date: Sun, 19 Apr 2009 20:55:38 -0700	[thread overview]
Message-ID: <49EBF23A.9070201@gmail.com> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E201C4497982@SC-VEXCH1.marvell.com>

Hi Prafulla,

Prafulla Wadaskar wrote:
<snip>
>>> +#define CONFIG_IPADDR		192.168.5.44
>>> +#define CONFIG_SERVERIP		192.168.5.30
>>> +#define CONFIG_NETMASK		255.255.255.0
>>>       
>> please remove the IP params
>>     
> Why ?
>
>   
Because these values are only relevant to your lab network, not anybody 
else who's going to use your boards. Boards should start with a clean 
slate. This is a hard rule that we've been enforcing for a while now - 
no address or network parameter initializations in config files.

regards,
Ben

  parent reply	other threads:[~2009-04-20  3:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 16:18 [U-Boot] [PATCH v2] Marvell MV88F6281GTW_GE Board support Prafulla Wadaskar
2009-04-08 21:53 ` Mike Frysinger
2009-04-14 17:30 ` Prafulla Wadaskar
2009-04-17  7:45 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-18  6:44   ` Prafulla Wadaskar
2009-04-18  7:33     ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-19  6:26       ` Prafulla Wadaskar
2009-04-19  8:35         ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20  3:55     ` Ben Warren [this message]
2009-04-22  5:59       ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EBF23A.9070201@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.