All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: Mikulas Patocka <mpatocka@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: possible regression by the barrier patch in 2.6.30-rc2
Date: Mon, 20 Apr 2009 13:27:00 +0900	[thread overview]
Message-ID: <49EBF994.90801@ct.jp.nec.com> (raw)
In-Reply-To: <20090417132252.GA7843@agk.fab.redhat.com>

Hi Alasdair, Mikulas,

On 2009/04/17 22:22 +0900, Alasdair G Kergon wrote:
> On Fri, Apr 17, 2009 at 01:57:02PM +0900, Kiyoshi Ueda wrote:
>> 1. The semantics of flush suspend has been changed.
> 
> We absolutely must complete any I/O issued as a result of the lock_fs()
> call in dm_suspend().

I think that lock_fs() waits for I/O to complete, so no semantics change
in case of LOCKFS && FLUSH. (All I/O issued from lock_fs() are flushed.)

But in case of NO_LOCKFS && FLUSH, the semantics is changed:
  from: I/Os submitted before the suspend invocation are flushed
  to:   I/Os submitted even before the suspend invocation may not be flushed

I have no idea whether someone gets real damage by this semantics change.

> Alasdair

Thanks,
Kiyoshi Ueda

  reply	other threads:[~2009-04-20  4:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17  4:57 possible regression by the barrier patch in 2.6.30-rc2 Kiyoshi Ueda
2009-04-17 13:22 ` Alasdair G Kergon
2009-04-20  4:27   ` Kiyoshi Ueda [this message]
2009-04-20  6:20     ` Mikulas Patocka
2009-10-28 15:21       ` Alasdair G Kergon
2009-11-05  1:53         ` Mikulas Patocka
2009-11-05  2:02           ` Mikulas Patocka
2009-11-06  2:42             ` snapshot of mirror (was: possible regression by the barrier patch in 2.6.30-rc2) Mikulas Patocka
2009-11-05  2:04           ` Re: possible regression by the barrier patch in 2.6.30-rc2 Alasdair G Kergon
2009-11-06  7:34         ` Kiyoshi Ueda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EBF994.90801@ct.jp.nec.com \
    --to=k-ueda@ct.jp.nec.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.