All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brice Goglin <brice@myri.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: David Dillow <dave@thedillows.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] myri10ge: allow per-board firmware overriding
Date: Mon, 20 Apr 2009 11:55:15 +0200	[thread overview]
Message-ID: <49EC4683.3060605@myri.com> (raw)
In-Reply-To: <20090420114041.37c7fa7b@dhcp-lab-109.englab.brq.redhat.com>

Stanislaw Gruszka wrote:
> Providing module_param_id would address this issues, but I have some concerns
> before doing it:
>
> - device have to access ID (like serial no) before initialization (at least
>   before driver will need parameter)
> - why nobody already done it - perhaps such thing would be totally useless
>   

Per-nic module parameters are used in some Intel NIC drivers but it's
not considered a very good solution in the general case:
   
http://kerneltrap.org/index.php?q=mailarchive/linux-netdev/2008/10/24/3801824/thread

But again, when talking about changing the NIC firmware, ethtool and
friends are not that easy.

Brice


  reply	other threads:[~2009-04-20  9:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 12:24 [PATCH net-next] myri10ge: allow per-board firmware overriding Brice Goglin
2009-04-17  0:57 ` David Miller
2009-04-17  7:50 ` Stanislaw Gruszka
2009-04-18 18:36   ` Brice Goglin
2009-04-19  0:56     ` David Dillow
2009-04-19  2:36       ` David Dillow
2009-04-20  9:40         ` Stanislaw Gruszka
2009-04-20  9:55           ` Brice Goglin [this message]
2009-04-20 11:53             ` Stanislaw Gruszka
2009-04-19  4:09       ` David Miller
2009-04-19  4:41         ` David Dillow
2009-04-19  5:25       ` Kyle Moffett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EC4683.3060605@myri.com \
    --to=brice@myri.com \
    --cc=dave@thedillows.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.