From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] Fix xenconsole after aborted save
Date: Mon, 20 Apr 2009 16:09:25 +0200
Message-ID: <49EC8215.6040800@redhat.com>
References: <20090420132353.GA20653@orkuz.home> <49EC7AE1.5060807@redhat.com>
	<20090420140436.GB18963@orkuz.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090420140436.GB18963@orkuz.home>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jiri Denemark <jdenemar@redhat.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 04/20/09 16:04, Jiri Denemark wrote:
> On Mon, Apr 20, 2009 at 15:38:41 +0200, Gerd Hoffmann wrote:
>> On 04/20/09 15:23, Jiri Denemark wrote:
>>> This patch modifies xenconsoled to check current status of open event channels
>>> and rebind them if necessary.
>> close() + open() is the sledge hammer approach (will work though).  Just
>> unbind(local_port) should be enough.
>
> It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in
> case the event channel is unbound. The close() + open() combination was there
> before... I haven't touched that code except for skipping it when only rebind
> is required.

Oh, ok, got the logic wrong.  The patch looks fine to me then.

cheers,
   Gerd