From: Johannes Sixt <j.sixt@viscovery.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Dmitry Potapov <dpotapov@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Kjetil Barvik <barvik@broadpark.no>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/2] Windows: Skip fstat/lstat optimization in write_entry()
Date: Mon, 20 Apr 2009 16:19:09 +0200 [thread overview]
Message-ID: <49EC845D.6020107@viscovery.net> (raw)
In-Reply-To: <81b0412b0904200654w1606a31fu227fa535cc14e10d@mail.gmail.com>
Alex Riesen schrieb:
> 2009/4/20 Dmitry Potapov <dpotapov@gmail.com>:
>> If the time passed between the creating file and end of writing to it is
>> small (less than timestamp resolution), you may not notice the problem.
>> The following program demonstrates the problem with fstat on Windows.
>> (I compiled it using Cygwin). If you remove 'sleep' then you may not
>> notice the problem for a long time.
>
> And the Windows being as slow as it is, the problem can stay undetected for
> a long time in a real working code.
You got that wrong: If Windows were slow, the error would have been
triggered more often and it would have been detected earlier. There you
have the proof: Windows is fast ... enough :-P
-- Hannes
next prev parent reply other threads:[~2009-04-20 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 8:17 [PATCH 2/2] Windows: Skip fstat/lstat optimization in write_entry() Johannes Sixt
2009-04-20 10:05 ` Johannes Schindelin
2009-04-20 11:03 ` Dmitry Potapov
2009-04-20 12:34 ` Hannu Koivisto
2009-04-20 12:58 ` Alex Riesen
2009-04-20 13:33 ` Dmitry Potapov
2009-04-20 13:54 ` Alex Riesen
2009-04-20 14:19 ` Johannes Sixt [this message]
2009-04-20 14:25 ` Alex Riesen
2009-04-20 14:27 ` Alex Riesen
2009-04-20 21:17 ` Junio C Hamano
2009-04-20 22:17 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EC845D.6020107@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=barvik@broadpark.no \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.