From: Brian King <brking@linux.vnet.ibm.com>
To: "Kleber S. Souza" <klebers@linux.vnet.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space()
Date: Mon, 20 Apr 2009 17:11:13 -0500 [thread overview]
Message-ID: <49ECF301.7050809@linux.vnet.ibm.com> (raw)
In-Reply-To: <1240255436.7458.145.camel@zeppelin.austin.ibm.com>
Acked by: Brian King <brking@linux.vnet.ibm.com>
Kleber S. Souza wrote:
> The key functions of the ipr driver call two macros defined in 'ipr.h',
> 'ENTER' and 'LEAVE', upon entering and leaving the functions, in order
> to print debug messages when the driver is loaded with the option
> 'debug=1'. Before returning, ipr_reset_restore_cfg_space() calls 'ENTER'
> where it should call 'LEAVE'. This patch calls the right macro before
> returning from the function.
>
>
>
> Signed-off-by: Kleber S. Souza <klebers@linux.vnet.ibm.com>
> ---
> drivers/scsi/ipr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index c09d775..23f4af2 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -6522,7 +6522,7 @@ static int ipr_reset_restore_cfg_space(struct
> ipr_cmnd *ipr_cmd)
> }
> }
>
> - ENTER;
> + LEAVE;
> return IPR_RC_JOB_CONTINUE;
> }
>
> --
>
>
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
prev parent reply other threads:[~2009-04-20 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 19:23 [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space() Kleber S. Souza
2009-04-20 22:11 ` Brian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ECF301.7050809@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=klebers@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.