From: Peter Rajnoha <prajnoha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/4] Udev integration: add LVM fields support for dmsetup
Date: Tue, 21 Apr 2009 20:47:09 +0200 [thread overview]
Message-ID: <49EE14AD.7050502@redhat.com> (raw)
In-Reply-To: <1240338923.3705.66.camel@f10-node1>
On 04/21/2009 08:35 PM, Dave Wysochanski wrote:
> A couple minor cleanup comments for this patch set:
> 1. Warnings when compiling these patches.
> ioctl/libdm-iface.c:867: warning: no previous prototype for ?dm_cookie_supported?
> dmsetup.c:332: warning: assignment discards qualifiers from pointer target type
Yes, I've noticed, too :) I've added proper casting here, so it's OK now...
> 2. whitespace / tabs - set to 8 spaces / tab?
> Areas I noticed were dm_cookie_supported() definitions and other
> indents.
...ok, I'll have a look
Thanks
Peter
prev parent reply other threads:[~2009-04-21 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 12:13 [PATCH 1/4] Udev integration: add LVM fields support for dmsetup Peter Rajnoha
2009-04-15 18:49 ` Alasdair G Kergon
2009-04-20 10:37 ` Peter Rajnoha
2009-04-21 18:35 ` Dave Wysochanski
2009-04-21 18:47 ` Peter Rajnoha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EE14AD.7050502@redhat.com \
--to=prajnoha@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.