From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wengang Wang <wen.gang.wang@oracle.com>
Date: Wed, 22 Apr 2009 23:41:59 +0800
Subject: [Ocfs2-devel] [PATCH 1/1] OCFS2: Log -EIO errors just when hit
 them.
In-Reply-To: <49E8F93B.40300@oracle.com>
References: <200904170744.n3H7iJac013765@acsinet15.oracle.com>
	<49E8F93B.40300@oracle.com>
Message-ID: <49EF3AC7.9050608@oracle.com>
List-Id: <ocfs2-devel.oss.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ocfs2-devel@oss.oracle.com

Hi Sunil and Joel,

For the EIO log problem, ocfs2_end_buffer_io_sync() is used as the 
callback function b_end_io
for both READ and WRITE.
I noticed that in this function,

if (!uptodate)
    mlog_errno(-EIO);

Isn't the 2 lines enough to log EIO errors?

regards,
wengang.

Sunil Mushran wrote:
> I imagine this is for the unlogged EIOs that have been reported.
>
> From my scan, at least in mainline, all these EIOs are being logged
> by the caller. So this patch is not adding any value. Can you double
> check that please?
>
> Now it could be that the reported EIOs are on 1.2/1.4 and that those
> trees are missing the mlogs. In that case, the patch should be specific
> to the tree.
>
> BTW, the (u64) should be (unsigned long long). This ensures that
> it compiles warning free on all arches.
>