From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Turton Subject: Re: [PATCH] Fix xenconsole after aborted save Date: Wed, 22 Apr 2009 17:15:17 +0100 Message-ID: <49EF4295.8010803@solarflare.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Jiri Denemark , Chris Lalancette , "xen-devel@lists.xensource.com" , Gerd Hoffmann List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > The suspend_cancel hook you are thinking of is for any PV devices which *do* > need to know that a suspend was cancelled. Netaccel does for some reason > which I cannot recall. For the record, netaccel needs to remove any mappings of the hardware during the suspend callback since those mappings are not valid after the suspend has completed. Those hardware mappings (or the mappings appropriate for the new machine) are restored on resume as a result of the standard netfront/netback connection being re-established. If the suspend is cancelled, the netfront/netback connection stays in place but the hardware mappings need to be re-established which is why the suspend_cancel callback is used. Cheers, Neil.