All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] implement qemu_blockalign
Date: Wed, 22 Apr 2009 15:22:11 -0500	[thread overview]
Message-ID: <49EF7C73.3070902@us.ibm.com> (raw)
In-Reply-To: <49E35345.1090004@eu.citrix.com>

Stefano Stabellini wrote:
> Hi all,
> this patch adds a buffer_alignment field to BlockDriverState and
> implements a qemu_blockalign function that uses that field to allocate a
> memory aligned buffer to be used by the block driver.
> buffer_alignment is initialized to 512 but each block driver can set
> a different value (at the moment none of them do).
> This patch modifies ide.c, block-qcow.c, block-qcow2.c and block.c to
> use qemu_blockalign instead of qemu_memalign.
> There is only one place left that still uses qemu_memalign to allocate
> buffers used by block drivers that is posix-aio-compat:handle_aiocb_rw
> because it is not possible to get the BlockDriverState from that
> function. However I think it is not important because posix-aio-compat
> already deals with driver specific code so it is supposed to know its
> own needs.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   
Applied.  Thanks.

-- 
Regards,

Anthony Liguori

      parent reply	other threads:[~2009-04-22 20:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-13 14:59 [Qemu-devel] [PATCH] implement qemu_blockalign Stefano Stabellini
2009-04-14 16:24 ` Christoph Hellwig
2009-04-14 17:03   ` Stefano Stabellini
2009-04-22 20:22 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EF7C73.3070902@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.