All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Steven Jan Springl <steven@springl.ukfsn.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: nf_conntrack_proto_udplite
Date: Thu, 23 Apr 2009 12:30:12 +0200	[thread overview]
Message-ID: <49F04334.9000905@trash.net> (raw)
In-Reply-To: <200904222106.29497.steven@springl.ukfsn.org>

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Steven Jan Springl wrote:
> Hello
> 
> Whilst testing kernel 2.6.30-rc3 I have noticed that when I issue command: 
> 
> modprobe nf_conntrack_proto_udplite
> 
> the following message is produced:
> 
> FATAL: Error inserting nf_conntrack_proto_udplite 
> (/lib/modules/2.6.30-rc3/kernel/net/netfilter/nf_conntrack_proto_udplite.ko): 
> Invalid argument
> 
> Is this a kernel bug or have I done something wrong?

Thanks for the report, it seems the IPv6 udplite protocol was
forgotten during a recent API change.

Does this patch help?


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 632 bytes --]

diff --git a/net/netfilter/nf_conntrack_proto_udplite.c b/net/netfilter/nf_conntrack_proto_udplite.c
index 4614696..0badedc 100644
--- a/net/netfilter/nf_conntrack_proto_udplite.c
+++ b/net/netfilter/nf_conntrack_proto_udplite.c
@@ -204,6 +204,7 @@ static struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite6 __read_mostly =
 	.error			= udplite_error,
 #if defined(CONFIG_NF_CT_NETLINK) || defined(CONFIG_NF_CT_NETLINK_MODULE)
 	.tuple_to_nlattr	= nf_ct_port_tuple_to_nlattr,
+	.nlattr_tuple_size	= nf_ct_port_nlattr_tuple_size,
 	.nlattr_to_tuple	= nf_ct_port_nlattr_to_tuple,
 	.nla_policy		= nf_ct_port_nla_policy,
 #endif

  reply	other threads:[~2009-04-23 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 20:06 nf_conntrack_proto_udplite Steven Jan Springl
2009-04-23 10:30 ` Patrick McHardy [this message]
2009-04-23 14:25   ` nf_conntrack_proto_udplite Steven Jan Springl
2009-04-23 22:24     ` nf_conntrack_proto_udplite Pablo Neira Ayuso
2009-04-24 13:02       ` nf_conntrack_proto_udplite Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F04334.9000905@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=steven@springl.ukfsn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.