Re: udev_queue_get_seqnum_is_finished

[Alan Jenkins <alan-jenkins@tuffmail.co.uk>]

Kay Sievers wrote:
> On Thu, Apr 23, 2009 at 13:20, Kay Sievers <kay.sievers@vrfy.org> wrote:
>   
>> On Thu, Apr 23, 2009 at 11:39, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>     
>
>   
>>> Shouldn't the test be (seqnum > udev_queue->last_seen_udev_seqnum) ?
>>> I.e. "greater than" instead of "less than".
>>>       
>> Sounds like.
>>     
>
> Care to check, if that makes sense now:
>   http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;hŒ3ae78546a535cc9288a190680fb1eb88c6ea7e
>   

Yes, that makes sense now.  Except for the comment, which seems to
accurately describes the old, confused code :-)

/* if we have not seen this seqnum, check if it is/was already queued */

to match the new code, I think it would be

/* if we have seen this seqnum, check if it is still queued */


Ta
Alan