All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Make the extent validity check more paranoid
Date: Thu, 23 Apr 2009 07:52:28 -0500	[thread overview]
Message-ID: <49F0648C.10407@redhat.com> (raw)
In-Reply-To: <20090423041914.GA2723@mit.edu>

Theodore Tso wrote:
> On Wed, Apr 22, 2009 at 09:04:30PM -0500, Eric Sandeen wrote:
>> Theodore Ts'o wrote:
>>> Instead of just checking that the extent block number is greater or
>>> equal than s_first_data_block, make sure it it is not pointing into
>>> the block group descriptors, since that is clearly wrong.  This helps
>>> prevent filesystem from getting very badly corrupted in case an extent
>>> block is corrupted.
>>>
>>> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>> Good idea.  Maybe we can get our friends with the corrupted fs to run
>> with these validation patches... I can get this into rawhide at least.
> 
> Yeah, unfortunately this patch requires some other patches that went
> in during the 2.6.30 merge window, so some extra back-porting would be
> needed for our friends running a 2.6.29.1 Fedora kernel.

Right, but rawhide has .30-etc, so a test on that might be helpful.

-Eric

      reply	other threads:[~2009-04-23 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23  1:29 [PATCH] ext4: Make the extent validity check more paranoid Theodore Ts'o
2009-04-23  2:04 ` Eric Sandeen
2009-04-23  4:19   ` Theodore Tso
2009-04-23 12:52     ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F0648C.10407@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.