From: Michael J Gruber <git@drmicha.warpmail.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] Documentation: replace sha1 by SHA-1
Date: Fri, 24 Apr 2009 17:30:46 +0200 [thread overview]
Message-ID: <49F1DB26.1070605@drmicha.warpmail.net> (raw)
In-Reply-To: <49F1D857.7060100@viscovery.net>
Johannes Sixt venit, vidit, dixit 24.04.2009 17:18:
> Michael J Gruber schrieb:
>> diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt
>> index 287c4fc..73e1dc4 100644
>> --- a/Documentation/git-fsck.txt
>> +++ b/Documentation/git-fsck.txt
>
> These hunks are in a section that talks about fsck's diagnostics.
Yes. I didn't notice they were actual warning message quotes though.
Thanks for catching it.
>
>> +missing SHA-1 directory '<dir>'::
>> + The directory holding the SHA-1 objects is missing.
>
> This message does not present in the code anywhere; it could be removed
> from this list.
Yes, that should be a patch before 1/2 then.
>
>> +SHA-1 mismatch <object>::
>
> And this one occurs in the code, and so it should be changed as well.
It comes from object.c rather than builtin-fsck.c, right?
I guess it shows that I should go through the code as well. But it's not
a good time for that now... (rc) I'll revert that specific change then.
Michael
next prev parent reply other threads:[~2009-04-24 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 14:49 [PATCH 0/2] Unify use of [sha,SHA][,-]1 Michael J Gruber
2009-04-24 14:49 ` [PATCH 1/2] Documentation: replace sha1 by SHA-1 Michael J Gruber
2009-04-24 14:49 ` [PATCH 2/2] Documentation: replace SHA1 " Michael J Gruber
2009-04-24 21:30 ` Jeff King
2009-04-24 15:18 ` [PATCH 1/2] Documentation: replace sha1 " Johannes Sixt
2009-04-24 15:23 ` Wincent Colaiuta
2009-04-24 15:33 ` Michael J Gruber
2009-04-24 15:30 ` Michael J Gruber [this message]
2009-04-24 21:28 ` Jeff King
2009-04-24 22:38 ` Junio C Hamano
2009-04-25 10:47 ` Felipe Contreras
2009-04-25 12:13 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F1DB26.1070605@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.