From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] OMAP3: Print correct silicon revision
Date: Fri, 24 Apr 2009 22:40:56 +0200 [thread overview]
Message-ID: <49F223D8.1090205@googlemail.com> (raw)
In-Reply-To: <20090424200623.GF2953@game.jcrosoft.org>
Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:49 Fri 24 Apr , Dirk Behme wrote:
>> Sanjeev Premi wrote:
>>> The function display_board_info() displays incorrect
>>> silicon revision - based on the return value from
>>> function get_cpu_rev().
>>>
>>> This patch fixes the problem.
>>>
>>> Signed-off-by: Sanjeev Premi <premi@ti.com>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>> Tested-by: Dirk Behme <dirk.behme@googlemail.com>
>
> why the twice?
I wanted to mention that I helped developing these patches and that I
tested them on real HW.
http://kerneltrap.org/node/8329:
"The Signed-off-by: tag implies that the signer was involved in the
development of the patch"
"Tested-by ... it's very useful information to have. For a start, it
tells you who has the hardware and knows how to build ..."
If you think one is enough, remove what you don't like ;)
Dirk
next prev parent reply other threads:[~2009-04-24 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 14:52 [U-Boot] [PATCH 2/2] OMAP3: Print correct silicon revision Sanjeev Premi
2009-04-24 16:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-24 19:29 ` Wolfgang Denk
2009-04-24 16:49 ` Dirk Behme
2009-04-24 20:06 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-24 20:40 ` Dirk Behme [this message]
2009-04-25 12:52 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-25 17:07 ` Ben Warren
2009-04-26 4:35 ` Dirk Behme
2009-04-26 4:34 ` [U-Boot] Using Signed-off-by, was: " Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F223D8.1090205@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.