From: Kevin Wolf <kwolf@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv'
Date: Mon, 27 Apr 2009 14:17:04 +0200 [thread overview]
Message-ID: <49F5A240.30204@redhat.com> (raw)
In-Reply-To: <49F5A0BC.90508@redhat.com>
Avi Kivity schrieb:
> Kevin Wolf wrote:
>> Avi Kivity schrieb:
>>> Instead of crowding the top-level directory, give block format
>>> drivers their
>>> very own subdirectory.
>>>
>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> I like this idea. In fact, I was going to suggest something like this
>> myself. And a good next step would be to split up (too) large source
>> files, e.g. into qcow2-snapshot.c, qcow2-refcount.c and so on.
>
> qcow2/snapshot.c qcow2/refcount.c ...
I'm not sure about that one. A less crowded top level directory is a
good thing, but building a directory labyrinth is not, IMHO.
Kevin
next prev parent reply other threads:[~2009-04-27 12:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 15:19 [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' Avi Kivity
2009-04-26 15:29 ` Christoph Hellwig
2009-04-26 15:55 ` Avi Kivity
2009-04-26 16:18 ` Blue Swirl
2009-04-26 16:20 ` Avi Kivity
2009-04-26 16:40 ` Blue Swirl
2009-04-26 17:04 ` Avi Kivity
2009-04-26 17:44 ` Anthony Liguori
2009-04-26 17:56 ` Christoph Hellwig
2009-04-26 18:06 ` Avi Kivity
2009-04-26 17:41 ` Anthony Liguori
2009-04-26 18:10 ` Blue Swirl
2009-04-26 21:26 ` Stefan Weil
2009-04-27 12:14 ` Kevin Wolf
2009-04-27 13:52 ` Jamie Lokier
2009-04-27 14:37 ` M. Warner Losh
2009-04-27 12:08 ` Kevin Wolf
2009-04-27 12:10 ` Avi Kivity
2009-04-27 12:17 ` Kevin Wolf [this message]
2009-05-02 10:34 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F5A240.30204@redhat.com \
--to=kwolf@redhat.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.