From: Jeff Garzik <jeff@garzik.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH v2] sparse: add LLVM code generation backend
Date: Mon, 27 Apr 2009 18:39:39 -0400 [thread overview]
Message-ID: <49F6342B.30605@garzik.org> (raw)
In-Reply-To: <70318cbf0904271215o48ac3952ua0aca68a50cba16d@mail.gmail.com>
Christopher Li wrote:
> On Sun, Apr 26, 2009 at 1:58 PM, Jeff Garzik <jeff@garzik.org> wrote:
>> + case EXPR_DEREF:
>> + case EXPR_SIZEOF:
>> + case EXPR_ALIGNOF:
>> + warning(expr->pos, "invalid expression after evaluation");
>> + return NULL;
>
> Regarding using liniearize instruction vs rolling your own.
>
> I don't think you can get more information than linearize instruction
> here. EXPR_DEREF has already been processed during evaluation.
Recall the history of the code: show-parse.c -> compile-i386.c ->
s2l-gen.c.
You can see the above code was taken verbatim from show-parse.c, and is
probably nothing more than a check the original author (Linus?) felt
appropriate at the time, for show-parse.c. I wouldn't read too much
into its presence in s2l-gen.c -- maybe those checks can simply be deleted.
Jeff
next prev parent reply other threads:[~2009-04-27 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 20:58 [PATCH v2] sparse: add LLVM code generation backend Jeff Garzik
2009-04-27 19:15 ` Christopher Li
2009-04-27 22:39 ` Jeff Garzik [this message]
2009-04-27 23:27 ` Christopher Li
2009-04-28 0:32 ` Jeff Garzik
2009-04-28 1:04 ` Christopher Li
2009-04-28 1:21 ` Jeff Garzik
2009-04-28 2:15 ` Christopher Li
2009-04-28 22:59 ` Christopher Li
2009-04-29 22:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F6342B.30605@garzik.org \
--to=jeff@garzik.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.