From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: [PATCH] scsi: ses check name in enclosure_component_register Date: Mon, 27 Apr 2009 19:18:53 -0700 Message-ID: <49F6678D.3080207@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:44308 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbZD1CTv (ORCPT ); Mon, 27 Apr 2009 22:19:51 -0400 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley , Andrew Morton , Kay Sievers , Greg KH Cc: "linux-kernel@vger.kernel.org" , Linux-Scsi dev_set_name will use sprintf to copy the name. need to check if the name does valid. otherwise will error from device_add later. Signed-off-by: Yinghai Lu diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index 3cf61ec..68743a9 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -255,7 +255,7 @@ enclosure_component_register(struct enclosure_device *edev, ecomp->number = number; cdev = &ecomp->cdev; cdev->parent = get_device(&edev->edev); - if (name) + if (name && name[0]) dev_set_name(cdev, name); else dev_set_name(cdev, "%u", number);