All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH v2] lockd: fix FILE_LOCKING=n build error
Date: Tue, 28 Apr 2009 14:01:00 -0700	[thread overview]
Message-ID: <49F76E8C.3070808@oracle.com> (raw)
In-Reply-To: <1240942554.7376.38.camel@heimdal.trondhjem.org>

Trond Myklebust wrote:
> Until someone finds time to go through the code and add in all the
> CONFIG_FILE_LOCKING special cases, the above needs to be a 'depends on
> INET && FILE_LOCKING'.

That seems to work.  Thanks.




From: Randy Dunlap <randy.dunlap@oracle.com>

lockd without FILE_LOCKING doesn't make sense, so make LOCKD and
LOCKD_V4 depend on FILE_LOCKING, and make NFS depend on FILE_LOCKING.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 fs/Kconfig     |    2 ++
 fs/nfs/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

--- linux-next-20090428.orig/fs/Kconfig
+++ linux-next-20090428/fs/Kconfig
@@ -226,10 +226,12 @@ source "fs/nfsd/Kconfig"
 
 config LOCKD
 	tristate
+	depends on FILE_LOCKING
 
 config LOCKD_V4
 	bool
 	depends on NFSD_V3 || NFS_V3
+	depends on FILE_LOCKING
 	default y
 
 config EXPORTFS
--- linux-next-20090428.orig/fs/nfs/Kconfig
+++ linux-next-20090428/fs/nfs/Kconfig
@@ -1,6 +1,6 @@
 config NFS_FS
 	tristate "NFS client support"
-	depends on INET
+	depends on INET && FILE_LOCKING
 	select LOCKD
 	select SUNRPC
 	select NFS_ACL_SUPPORT if NFS_V3_ACL

  reply	other threads:[~2009-04-28 21:01 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  6:53 linux-next: Tree for April 28 Stephen Rothwell
2009-04-28 11:10 ` Next April 28: boot failure on PowerPC with SLQB Sachin Sant
2009-04-28 11:22   ` Pekka Enberg
2009-04-28 11:22     ` Pekka Enberg
2009-04-29  7:04     ` Nick Piggin
2009-04-29  7:04       ` Nick Piggin
2009-04-29 11:36     ` Nick Piggin
2009-04-29 11:36       ` Nick Piggin
2009-04-29 16:26       ` Sachin Sant
2009-04-29 16:26         ` Sachin Sant
2009-04-30  3:21         ` Stephen Rothwell
2009-04-30  3:21           ` Stephen Rothwell
2009-04-30  3:21           ` Stephen Rothwell
2009-04-30  4:11         ` Nick Piggin
2009-04-30  4:11           ` Nick Piggin
2009-04-30  5:36           ` Sachin Sant
2009-04-30  5:36             ` Sachin Sant
2009-04-30  6:03             ` Nick Piggin
2009-04-30  6:03               ` Nick Piggin
2009-04-30  6:42               ` Sachin Sant
2009-04-30  6:42                 ` Sachin Sant
2009-04-30  6:41             ` Nick Piggin
2009-04-30  6:41               ` Nick Piggin
2009-04-30  9:47               ` Sachin Sant
2009-04-30  9:47                 ` Sachin Sant
2009-04-30 10:35                 ` Nick Piggin
2009-04-30 10:35                   ` Nick Piggin
2009-04-30 10:38                   ` Pekka Enberg
2009-04-30 10:38                     ` Pekka Enberg
2009-04-30 11:00                     ` Stephen Rothwell
2009-04-30 11:00                       ` Stephen Rothwell
2009-04-30 11:10                       ` Pekka Enberg
2009-04-30 11:10                         ` Pekka Enberg
2009-04-30 11:18                       ` Nick Piggin
2009-04-30 11:18                         ` Nick Piggin
2009-04-30 11:20                         ` Pekka Enberg
2009-04-30 11:20                           ` Pekka Enberg
2009-04-30 11:26                           ` Nick Piggin
2009-04-30 11:26                             ` Nick Piggin
2009-04-30 13:05                           ` Nick Piggin
2009-04-30 13:05                             ` Nick Piggin
2009-04-30 14:00                             ` Stephen Rothwell
2009-04-30 14:00                               ` Stephen Rothwell
2009-04-30 14:10                               ` Nick Piggin
2009-04-30 14:10                                 ` Nick Piggin
2009-05-03 11:51                                 ` Pekka Enberg
2009-05-03 11:51                                   ` Pekka Enberg
2009-04-30 14:10                             ` Anton Vorontsov
2009-04-30 14:10                               ` Anton Vorontsov
2009-05-03 11:51                               ` Pekka Enberg
2009-04-28 15:22 ` [PATCH] lockd: fix FILE_LOCKING=n build error Randy Dunlap
2009-04-28 15:38   ` Felix Blyakher
2009-04-28 17:21   ` J. Bruce Fields
2009-04-28 17:51     ` Randy Dunlap
2009-04-28 18:15       ` Trond Myklebust
2009-04-28 21:01         ` Randy Dunlap [this message]
2009-04-28 21:40           ` [PATCH v2] " J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F76E8C.3070808@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sfr@canb.auug.org.au \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.