From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Fix qemu_event_init
Date: Wed, 29 Apr 2009 00:59:01 +0200 [thread overview]
Message-ID: <49F78A35.2060603@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Falling through to "fail" made qemu_event_init() close the pipe fds
immediately again, breaking timer event notification.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
vl.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index a210b6c..ac4b32f 100644
--- a/vl.c
+++ b/vl.c
@@ -3713,6 +3713,8 @@ static int qemu_event_init(void)
(void *)(unsigned long)fds[0]);
io_thread_fd = fds[1];
+ return 0;
+
fail:
close(fds[0]);
close(fds[1]);
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next reply other threads:[~2009-04-28 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 22:59 Jan Kiszka [this message]
2009-04-29 18:43 ` [Qemu-devel] [PATCH] Fix qemu_event_init Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F78A35.2060603@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.