From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Wed, 29 Apr 2009 08:29:22 +0000 Subject: Re: qemu-kvm.git now live Message-Id: <49F80FE2.5030600@redhat.com> List-Id: References: <49F08BD0.6000706@redhat.com> <1240955602.24625.57.camel@slate.austin.ibm.com> In-Reply-To: <1240955602.24625.57.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hollis Blanchard Cc: KVM list , kvm-ppc Hollis Blanchard wrote: > On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: > >> Still missing: >> - I have not tested powerpc or ia64. Patches welcome! >> > > This repository seems pretty messed up; I'm not even sure what you want > from me. Some of the bigger problems: > > * configure completely ignores --kerneldir and only uses > kvm/kernel headers instead. > That's intentional. > * The headers in kvm/kernel/arch/foo seem to be the important > ones, but they have odd ifdefs at the top and I'm not sure how > they should be generated. > They were generated by the old 'make sync' to remove CONFIG_ dependencies. I guess a better way to generate them is a 'make headers-install' from the kernel tree and grab the results. > * "make -C kvm/kernel sync" doesn't even come close to working. > One of the goals of qemu-kvm.git was to have a standalone repository so I could release kvm-kmod and qemu-kvm independently. > There are a host of other issues and confusing issues, even with a fresh > checkout. In general it seems like the mess that was kvm-userspace has > been rearranged, and as a consequence is even worse than before. > Can you detail specific grievances? Please exclude temporary brokenness that was the result of the change. > How am I supposed to create kvm/kernel/arch/powerpc/include/asm/*? Just > cp from a Linux tree, or must I add funny ifdefs somehow? > cp from a Linux tree won't compile. The results of the old 'make sync' would do, but a 'make headers-install' is probably better. > Here's one patch that I think will be needed: > > > Set kvm_arch=powerpc for PPC builds. > > The name of the Linux arch directory is "powerpc", not "ppc". > > Signed-off-by: Hollis Blanchard > > diff --git a/configure b/configure > index fc0fb9b..257cf02 100755 > --- a/configure > +++ b/configure > @@ -816,6 +816,9 @@ case "$cpu" in > i386 | x86_64) > kvm_arch="x86" > ;; > + ppc) > + kvm_arch="powerpc" > + ;; > *) > kvm_arch="$cpu" > ;; > > > Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm.git now live Date: Wed, 29 Apr 2009 11:29:22 +0300 Message-ID: <49F80FE2.5030600@redhat.com> References: <49F08BD0.6000706@redhat.com> <1240955602.24625.57.camel@slate.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , kvm-ppc To: Hollis Blanchard Return-path: In-Reply-To: <1240955602.24625.57.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: > >> Still missing: >> - I have not tested powerpc or ia64. Patches welcome! >> > > This repository seems pretty messed up; I'm not even sure what you want > from me. Some of the bigger problems: > > * configure completely ignores --kerneldir and only uses > kvm/kernel headers instead. > That's intentional. > * The headers in kvm/kernel/arch/foo seem to be the important > ones, but they have odd ifdefs at the top and I'm not sure how > they should be generated. > They were generated by the old 'make sync' to remove CONFIG_ dependencies. I guess a better way to generate them is a 'make headers-install' from the kernel tree and grab the results. > * "make -C kvm/kernel sync" doesn't even come close to working. > One of the goals of qemu-kvm.git was to have a standalone repository so I could release kvm-kmod and qemu-kvm independently. > There are a host of other issues and confusing issues, even with a fresh > checkout. In general it seems like the mess that was kvm-userspace has > been rearranged, and as a consequence is even worse than before. > Can you detail specific grievances? Please exclude temporary brokenness that was the result of the change. > How am I supposed to create kvm/kernel/arch/powerpc/include/asm/*? Just > cp from a Linux tree, or must I add funny ifdefs somehow? > cp from a Linux tree won't compile. The results of the old 'make sync' would do, but a 'make headers-install' is probably better. > Here's one patch that I think will be needed: > > > Set kvm_arch=powerpc for PPC builds. > > The name of the Linux arch directory is "powerpc", not "ppc". > > Signed-off-by: Hollis Blanchard > > diff --git a/configure b/configure > index fc0fb9b..257cf02 100755 > --- a/configure > +++ b/configure > @@ -816,6 +816,9 @@ case "$cpu" in > i386 | x86_64) > kvm_arch="x86" > ;; > + ppc) > + kvm_arch="powerpc" > + ;; > *) > kvm_arch="$cpu" > ;; > > > Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html