From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [RFC v14][PATCH 08/54] Dump memory address space Date: Wed, 29 Apr 2009 16:00:57 -0400 Message-ID: <49F8B1F9.40709@cs.columbia.edu> References: <1240961064-13991-1-git-send-email-orenl@cs.columbia.edu> <1240961064-13991-9-git-send-email-orenl@cs.columbia.edu> <20090429041128.GA28018@us.ibm.com> <20090429064241.GA17482@redback.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090429064241.GA17482-gvzKVTG1yJJBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Guenter Roeck Cc: "containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Dave Hansen List-Id: containers.vger.kernel.org Guenter Roeck wrote: > On Tue, Apr 28, 2009 at 09:11:28PM -0700, Serge E. Hallyn wrote: >> Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): >>> +#if CONFIG_CHEKCPOINT > ^^^^^^^^^^ > CONFIG_CHECKPOINT ? > Hmmm ... :( Will fix, thanks. Oren. > Guenter > >>> +static int special_mapping_checkpoint(struct ckpt_ctx *ctx, >>> + struct vm_area_struct *vma) >>> +{ >>> + char *name; >>> + >>> + /* >>> + * Currently, we only handle VDSO/vsyscall special handling. >>> + * Even that, is very basic - we just skip the contents and >>> + * hope for the best in terms of compatilibity upon restart. >>> + */ >>> + >>> + if (vma->vm_flags & CKPT_VMA_NOT_SUPPORTED) >>> + return -ENOSYS; >>> + >>> + name = arch_vma_name(vma); >>> + if (!name || strcmp(vma_name, "[vdso]")) >> Not important except for bisect-safety, as it's fixed in the next >> patch, but this should be name, not vma_name. >> >> -serge >> _______________________________________________ >> Containers mailing list >> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org >> https://lists.linux-foundation.org/mailman/listinfo/containers >