All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Marchand <jmarchan@redhat.com>
To: Nikanth K <nikanth@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org,
	Nikanth Karthikesan <knikanth@suse.de>
Subject: Re: [PATCH] block: remove unused __REQ_NR_BITS
Date: Thu, 30 Apr 2009 10:42:27 +0200	[thread overview]
Message-ID: <49F96473.5070401@redhat.com> (raw)
In-Reply-To: <807b3a220904300112vf8e77e5g5075eeb8f63e029d@mail.gmail.com>

Hi Nikanth,

Never mind, I missed your patch.

Jerome

Nikanth K wrote:
> Hi Jerome
> 
> On Wed, Apr 29, 2009 at 7:31 PM, Jerome Marchand <jmarchan@redhat.com> wrote:
>> Removes __REQ_NR_BITS which is not used since its only user
>> (blk_dump_rq_flags()) stopped to use it.
>>
> 
> See http://lkml.org/lkml/2009/4/27/140
> 
> A user for it is added by a patch in linux-2.6-block#for-2.6.31
> see http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commit;h=9eb55b030c4b3227334ee4482402096cd1d1a6fe
> 
> Thanks
> Nikanth
> 
>> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
>> ---
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 2755d5c..a101821 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -119,7 +119,6 @@ enum rq_flag_bits {
>>        __REQ_INTEGRITY,        /* integrity metadata has been remapped */
>>        __REQ_NOIDLE,           /* Don't anticipate more IO after this one */
>>        __REQ_IO_STAT,          /* account I/O stat */
>> -       __REQ_NR_BITS,          /* stops here */
>>  };
>>
>>  #define REQ_RW         (1 << __REQ_RW)
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>


      reply	other threads:[~2009-04-30  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 14:01 [PATCH] block: remove unused __REQ_NR_BITS Jerome Marchand
2009-04-30  8:12 ` Nikanth K
2009-04-30  8:42   ` Jerome Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F96473.5070401@redhat.com \
    --to=jmarchan@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=knikanth@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikanth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.