All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Florian Fainelli <florian@openwrt.org>,
	Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] flash_setup should only be built when CONFIG_MTD is enabled
Date: Thu, 30 Apr 2009 08:54:10 -0700	[thread overview]
Message-ID: <49F9C9A2.2000602@caviumnetworks.com> (raw)
In-Reply-To: <200904301748.52718.florian@openwrt.org>

Florian Fainelli wrote:

> This patch makes flash_setup be compiled only when CONFIG_MTD
> which solves issue, the MTD driver then fails to register but this is
> less critical.
> 
> CC: David Daney <ddaney@caviumnetworks.com>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Acked-by: David Daney <ddaney@caviumnetworks.com>

> ---
> diff --git a/arch/mips/cavium-octeon/Makefile b/arch/mips/cavium-octeon/Makefile
> index d6903c3..32bdc81 100644
> --- a/arch/mips/cavium-octeon/Makefile
> +++ b/arch/mips/cavium-octeon/Makefile
> @@ -10,9 +10,10 @@
>  #
>  
>  obj-y := setup.o serial.o octeon-irq.o csrc-octeon.o
> -obj-y += dma-octeon.o flash_setup.o
> +obj-y += dma-octeon.o
>  obj-y += octeon-memcpy.o
>  
>  obj-$(CONFIG_SMP)                     += smp.o
> +obj-$(CONFIG_MTD)		+= flash_setup.o
>  
>  EXTRA_CFLAGS += -Werror
> 

  reply	other threads:[~2009-04-30 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30 15:48 [PATCH] flash_setup should only be built when CONFIG_MTD is enabled Florian Fainelli
2009-04-30 15:54 ` David Daney [this message]
2009-05-01 13:47 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F9C9A2.2000602@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.