Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3

[David Ahern <dsahern@gmail.com>]

Anthony Liguori wrote:
> David Ahern wrote:
>> Did not see a response to the last version.
>>
>> This patch enables TCP keepalives on VNC connections and TCP-based char
>> devices.
>>
>> Default parameters have keep alive probes sent after 60-seconds of idle
>> time. Probes are sent every 12 seconds with the connection resetting
>> after 5 failed probes (ie., connection is closed if no response received
>> in 60-seconds).
>>
>> Changes v2 -> v3
>> Removed duplicate definition and fixed typo in comments.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>>
>>
>> david
>>   
> This patch introduces a warning:
> 
> /home/anthony/git/qemu/vnc.c:2039: warning: implicit declaration of
> function ‘enable_tcp_keepalive’
> 

Missed that. Forgot to add net.h to vnc.c.

Before I re-send a patch, what's the feeling regarding enabling this all
the time versus a command line option to control it?

david