From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M02Qm-00075W-1o
	for qemu-devel@nongnu.org; Fri, 01 May 2009 19:46:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M02Qh-0006wT-HQ
	for qemu-devel@nongnu.org; Fri, 01 May 2009 19:46:11 -0400
Received: from [199.232.76.173] (port=42146 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M02Qh-0006wJ-E3
	for qemu-devel@nongnu.org; Fri, 01 May 2009 19:46:07 -0400
Received: from pop-borzoi.atl.sa.earthlink.net ([207.69.195.70]:33103)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <reif@earthlink.net>) id 1M02Qh-0004sN-5U
	for qemu-devel@nongnu.org; Fri, 01 May 2009 19:46:07 -0400
Message-ID: <49FB88C8.9060906@earthlink.net>
Date: Fri, 01 May 2009 19:42:00 -0400
From: Robert Reif <reif@earthlink.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] 64 bit I/O support v7
References: <49EDB109.5010009@earthlink.net>	<200905011514.21072.paul@codesourcery.com>	<49FB09B9.7020701@earthlink.net>	<200905011552.48991.paul@codesourcery.com>
	<49FB1302.4090904@earthlink.net>
In-Reply-To: <49FB1302.4090904@earthlink.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Robert Reif wrote:
>
> static void nvram_writel (void *opaque, target_phys_addr_t addr, 
> uint32_t value)
> {
>    m48t59_t *NVRAM = opaque;
>
>    m48t59_write(NVRAM, addr, (value >> 24) & 0xff);
>    m48t59_write(NVRAM, addr + 1, (value >> 16) & 0xff);
>    m48t59_write(NVRAM, addr + 2, (value >> 8) & 0xff);
>    m48t59_write(NVRAM, addr + 3, value & 0xff);
> }
>
static void cirrus_vga_mem_writel(void *opaque, target_phys_addr_t addr, 
uint32_t val)
{
#ifdef TARGET_WORDS_BIGENDIAN
    cirrus_vga_mem_writeb(opaque, addr, (val >> 24) & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 1, (val >> 16) & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 2, (val >> 8) & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 3, val & 0xff);
#else
    cirrus_vga_mem_writeb(opaque, addr, val & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 1, (val >> 8) & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 2, (val >> 16) & 0xff);
    cirrus_vga_mem_writeb(opaque, addr + 3, (val >> 24) & 0xff);
#endif
}

Should a new intermediate bus layer also do byte swapping?