Re: [Qemu-devel] [PATCH] Import KVM headers including Makefile and import script

[Avi Kivity <avi@redhat.com>]

Anthony Liguori wrote:
> These are the headers from Linux 2.6.29 that have been modified to work under
> QEMU.  This includes the necessary scripts to generate the headers from the
> original Linux source tree.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  configure                      |    7 +-
>  include/HEAD                   |    1 +
>  include/Makefile               |   26 ++
>  include/README                 |    6 +
>  include/asm-powerpc/kvm.h      |   55 ++++
>  include/asm-powerpc/kvm_para.h |   37 +++
>  include/asm-x86/kvm.h          |  218 ++++++++++++++++
>  include/asm-x86/kvm_para.h     |  147 +++++++++++
>  include/fixup.sed              |   11 +
>  include/linux/kvm.h            |  533 ++++++++++++++++++++++++++++++++++++++++
>  include/linux/kvm_para.h       |   44 ++++
>   

Can we put them under kvm/, as include/ looks like a generic include 
directory, which this isn't.  Also, this generates a gratuitous conflict 
with qemu-kvm.git, and we have enough of those already.

I also suggest using arch/*/include/asm as a way of avoiding the 
symlink, instead of the extra hack in fixup.sed.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.